Skip to content

chore(alb): migrate to new SDK structure#1415

Merged
GokceGK merged 7 commits into
mainfrom
chore/STACKITCLI-355-alb-sdk-migration
May 20, 2026
Merged

chore(alb): migrate to new SDK structure#1415
GokceGK merged 7 commits into
mainfrom
chore/STACKITCLI-355-alb-sdk-migration

Conversation

@GokceGK
Copy link
Copy Markdown
Contributor

@GokceGK GokceGK commented May 20, 2026

Description

relates to STACKITCLI-355

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGK
chore(alb): migrate to new SDK structure
3c2dac3 
relates to STACKITCLI-355
@GokceGK GokceGK requested a review from a team as a code owner May 20, 2026 06:12
@GokceGK GokceGK marked this pull request as draft May 20, 2026 06:12
@GokceGK GokceGK marked this pull request as ready for review May 20, 2026 11:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/create 46.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/delete 27.59% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/describe 48.75% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/list 34.62% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/add 54.05% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/delete 32.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/describe 57.14% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/list 55.26% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/update 43.48% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/plans 34.15% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/pool/update 51.52% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/quotas 50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/template 34.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/update 39.53% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/alb/client 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/create/create.go 46.38% (ø) 69 32 37
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/delete/delete.go 27.59% (ø) 29 8 21
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/describe/describe.go 48.75% (ø) 80 39 41
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/list/list.go 34.62% (ø) 52 18 34
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/add/add.go 54.05% (ø) 37 20 17
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/delete/delete.go 32.00% (ø) 25 8 17
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/describe/describe.go 57.14% (ø) 35 20 15
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/list/list.go 55.26% (ø) 38 21 17
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/update/update.go 43.48% (ø) 46 20 26
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/plans/plans.go 34.15% (ø) 41 14 27
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/pool/update/update.go 51.52% (ø) 66 34 32
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/quotas/quotas.go 50.00% (ø) 36 18 18
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/template/template.go 34.38% (ø) 32 11 21
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/update/update.go 39.53% (ø) 86 34 52
github.com/stackitcloud/stackit-cli/internal/pkg/services/alb/client/client.go 0.00% (ø) 1 0 1

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/add/add_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/observability-credentials/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/plans/plans_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/pool/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/quotas/quotas_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/update/update_test.go

cgoetz-inovex
cgoetz-inovex approved these changes May 20, 2026
View reviewed changes
Comment thread internal/cmd/beta/alb/pool/update/update.go
@GokceGK GokceGK merged commit c8e094f into main May 20, 2026
3 checks passed
@GokceGK GokceGK deleted the chore/STACKITCLI-355-alb-sdk-migration branch May 20, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgoetz-inovex cgoetz-inovex cgoetz-inovex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GokceGK @cgoetz-inovex